-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[typescript/sdk-gen] Generate JS doc comments for output-versioned invokes #11511
Conversation
Changelog[uncommitted] (2022-12-05)Bug Fixes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I'm pretty sure the azure-native test failures in codegen are unrelated.
pkg/codegen/nodejs/gen.go
Outdated
@@ -1197,7 +1204,7 @@ func (mod *modContext) genFunctionOutputVersion( | |||
|
|||
fmt.Fprintf(w, ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new line here (directly after `) is causing a blank line between the function comments and declaration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it ✅
994a9b0
to
10e69f3
Compare
bors merge |
Build succeeded: |
any
type within apply lambdaThis is part of #11418 but irrelevant to that (big) PR so this will help make the changes smaller and more clear
Checklist
make changelog
and committed thechangelog/pending/<file>
documenting my change